Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the content at the top of the page #916

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Sep 6, 2022

Fix #908
In the current implementation we were using the "space-between" justification for .bd-article-container as there is now a .bd-header-article bar as first item, the .bd-article is systematically pushed at the bottom of the page.

By using start we ensure that the content is always on top.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to me, although I'm not sure why we don't see this in our documentation. E.g. wouldn't we expect the "snap to bottom" to exist on this page:

https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/persistent-search-field.html

?

Either way it seems fine to me 🤷

@12rambau
Copy link
Collaborator Author

12rambau commented Sep 7, 2022

I think it's working on this very page because there's the prev-next footer, footer that I don't have in my documentation.

@12rambau 12rambau merged commit 112b212 into pydata:main Sep 7, 2022
@12rambau 12rambau deleted the container branch September 7, 2022 15:44
@choldgraf
Copy link
Collaborator

Ahh that's why we didn't catch it then. Good find

@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small content is fixed to the bottom of the page
3 participants